Skip to content

Remove function for imagestreamtag #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove function for imagestreamtag #67

wants to merge 1 commit into from

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa commented Sep 20, 2024 •
edited
Loading

What changes have been made

Remove function for imagestreamtag

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested a review from Bobbins228 September 20, 2024 10:41
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChughShilpa
Once this PR has been reviewed and has the lgtm label, please assign sutaakar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sutaakar
Copy link
Contributor

The function can stay here.
Is there some specific reason to remove it?

@ChughShilpa
Copy link
Contributor Author

ChughShilpa commented Sep 20, 2024 •
edited
Loading

The function can stay here. Is there some specific reason to remove it?

I added this function to use in customRayImage test, since we have modified the customRayImage test and this function is not used anywhere else so thought to remove it

@sutaakar
Copy link
Contributor

As it is a general function it can be kept.

@ChughShilpa
Copy link
Contributor Author

As it is a general function it can be kept.

I am fine with it

@ChughShilpa
Copy link
Contributor Author

Closing the PR

@ChughShilpa ChughShilpa deleted the remove_istag branch September 20, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti Awaiting requested review from astefanutti

@Bobbins228 Bobbins228 Awaiting requested review from Bobbins228

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChughShilpa @sutaakar